prove speed

app/Http/Controllers/Api/GeneralInnerServiceController.php

@@ -174,34 +174,23 @@ class GeneralInnerServiceController extends Controller
         if ($this->oid == 0) return json_decode(json_encode(['code' => $this->apicode, 'msg' => GeneralConst::$apiMap[ $this->apicode ], 'data' => []], JSON_NUMERIC_CHECK), true);
         // 服務層
         $orlIds = $request->input('orlId');
-        $result = $this->urlManagementSv->takeOrlPV($orlIds, $this->oid);
+        $datesegs = $request->input('dateseg');
+        $result = $this->urlManagementSv->takeOrlPV($orlIds, $this->oid,$datesegs);
         // 整理返回資料
         $data = [];
         if (!empty($result)) {
-            foreach($result as $dataPV){
-                $data[$dataPV["serno"]] = $dataPV["pv"];
+            if($datesegs == "Y"){
+                foreach($result as $dataPV){
+                    $data[$dataPV["serno"]]["pv"] = $dataPV["pv"];
+                    $data[$dataPV["serno"]]["cdate"] = $dataPV["cdate"];
+                }
+            }else{
+                foreach($result as $dataPV){
+                    $data[$dataPV["serno"]] = $dataPV["pv"];
+                }
             }
         }
         // 返回
         return json_decode(json_encode(['code' => GeneralConst::API_OK, 'msg' => GeneralConst::$apiMap[ GeneralConst::API_OK ], 'data' => $data], JSON_NUMERIC_CHECK), true);       
     }
-    
-    public function datesegById(Request $request){ 
-        // 鑒權
-        if ($this->oid == 0) return json_decode(json_encode(['code' => $this->apicode, 'msg' => GeneralConst::$apiMap[ $this->apicode ], 'data' => []], JSON_NUMERIC_CHECK), true);
-        // 服務層
-        $orlId = $request->input('orlId');
-        $result = $this->urlManagementSv->getDatesegById($orlId, $this->oid);
-        // 整理返回資料
-        $data = array();
-        $tmp = '';
-        for ($i = 0; $i < count($result); $i++) {            
-            $data[] = [
-                'date' => $result[ $i ]["date"],
-                'cnt'  => $result[ $i ]["cnt"],
-            ];
-        }
-        // 返回
-        return json_decode(json_encode(['code' => GeneralConst::API_OK, 'msg' => GeneralConst::$apiMap[ GeneralConst::API_OK ], 'data' => $data], JSON_NUMERIC_CHECK), true);       
-    }
 }

app/Http/Services/Backend/DataManagement/UrlManagementService.php

@@ -177,34 +177,40 @@ class UrlManagementService
         return $url;
     }
     
-    public function takeOrlPV($ids, $oid)
+    public function takeOrlPV($ids, $oid,$datesegs="N")
     {
         // 取得參數
         // 調用資料庫(或者其他業務邏輯)
+        $groupByStr = "dataManagement_urlManagement_visit.code";
+        $takePVSelector = array('dataManagement_urlManagement_visit.code',\DB::raw("count(*) as uv_count "));
+        $urlSelector = array('serno',\DB::raw("ifnull(uv_count, 0) as pv"));
+        if($datesegs == "Y"){
+            $groupByStr .= ", left(dataManagement_urlManagement_visit.cdate, 10) asc";
+            $urlSelector = array('serno',\DB::raw("ifnull(uv_count, 0) as pv"),"uv.cdate");
+            $takePVSelector = array('dataManagement_urlManagement_visit.code',\DB::raw("count(*) as uv_count "),\DB::raw('left(cdate, 10) as cdate'));
+        }
+        $takePV = $this->urlManagementVisitDb
+            ->select($takePVSelector)
+            ->whereIn('dataManagement_urlManagement_visit.code', function ($query) use ($ids,$oid) {
+                $query->select('code')
+                    ->from('dataManagement_urlManagement')
+                    ->whereIn('serno', $ids);
+                if ($oid != GeneralConst::ID_ADMIN) {
+                    $query = $query->where('oid', $oid);
+                }
+            });
+        $takePV = $takePV->groupBy(\DB::raw($groupByStr));
         $url = $this->urlManagementDb
-            ->select([
-                'serno',
-                'title',
-                'url',
-                \DB::raw("concat('" . env('ORL_URL') . "', code, '') as code"),
-                'memo',
-                'valid',
-            ]);
-            
-        $url = $this->urlManagementDb
-        ->select([
-            'dataManagement_urlManagement.serno',
-            \DB::raw("ifnull(uv_count, 0) as pv"),
-        ])
-        ->leftjoin(\DB::raw("(select v.code, count(*) as uv_count from dataManagement_urlManagement_visit as v where (cdate >= '1900-01-01 00:00:00' and cdate <= '2050-12-31 23:59:59') group by v.code) as uv"), 'dataManagement_urlManagement.code', '=', 'uv.code');
+                ->select($urlSelector)
+                ->leftjoin(\DB::raw("({$takePV->toSql()}) as uv"), 'dataManagement_urlManagement.code', '=', 'uv.code')
+                ->mergeBindings($takePV->getQuery());
+
         // 權限判斷
         if ($oid != GeneralConst::ID_ADMIN) {
-            $url = $url
-                ->where('oid', '=', $oid);
+            $url = $url->where('oid',$oid);
         }
-        $url = $url
-            ->whereIn('serno', $ids)
-            ->get();
+        $url = $url->whereIn('serno', $ids);
+        $url = $url->get();
         if (is_null($url)) {
             return [];
         }